fix: removed code smells and refactored project structure#141
Open
sumitx28 wants to merge 1 commit intoSeleniumHQ:masterfrom
Open
fix: removed code smells and refactored project structure#141sumitx28 wants to merge 1 commit intoSeleniumHQ:masterfrom
sumitx28 wants to merge 1 commit intoSeleniumHQ:masterfrom
Conversation
|
Sumit Mansukhlal Savaliya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
rbri
requested changes
Dec 17, 2023
| private final HtmlUnitDriver driver_; | ||
| private AlertHolder holder_; | ||
| private boolean quitting_; | ||
| private boolean autoDismissOnQuit; |
Collaborator
There was a problem hiding this comment.
better naming makes sense but please stay with the overall rule to add a _ at the end
| } | ||
| } | ||
|
|
||
| private void waitFor(int time) { |
Collaborator
There was a problem hiding this comment.
any plans to reuse this somewhere else?
| return alert; | ||
| } | ||
|
|
||
| private static boolean isAlertTimedOut(WebWindow alertWindow , WebWindow currentWindow) { |
Collaborator
There was a problem hiding this comment.
looks a bit strange, when checking the method for figuring out why the alerts timed out i will not see anything regarding a timeout - maybe a better name?
| return ScriptRuntime.toCharSequence(ScriptableObject.getProperty(scriptable, lowerName)).toString(); | ||
| } | ||
|
|
||
| // js disabled, fallback to some hacks |
Collaborator
There was a problem hiding this comment.
a can't see any improvement from these changes in terms of readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.